Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: href property issue in gatsby build #580

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

Description:

This PR fixes the following href property issue in gatsby build:

Screenshot 2023-10-13 at 3 59 55 PM

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi self-assigned this Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a5917c2) 83.19% compared to head (1db5e43) 83.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   83.19%   83.22%   +0.03%     
==========================================
  Files          40       40              
  Lines        1071     1073       +2     
  Branches      195      197       +2     
==========================================
+ Hits          891      893       +2     
  Misses        168      168              
  Partials       12       12              
Files Coverage Δ
src/utils.js 97.43% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi merged commit 17876b8 into master Oct 13, 2023
6 checks passed
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi deleted the Ali-Abbas/gatsby-fix branch October 13, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants