Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early failure message when backend is down. #156

Closed

Conversation

adeelkhan
Copy link

WIP:
This patch would enable MFE to fail early just in
case of backend (LMS) is down and it want to show some user
facing page instead of showing a blank page.

VAN-129

case of backend is down and it want to show some user
facing page instead of showing a blank page.

VAN-129
@davidjoy davidjoy self-requested a review March 15, 2021 12:07
@davidjoy
Copy link
Contributor

Some initial thoughts -

  1. Can you describe in a bit more detail the situation this is addressing? I'm not sure I understand what issues we're running into.
  2. I think if we provide an option for this, it should likely be an option on the initialize function which can be passed in when the application is started up. If an application is providing some alternate handling, then that won't be changing on a per-deployment basis. Environment variables are useful for when we want to change behavior depending on the environment (dev, prod, Open edX instances, etc.), but I don't think that's the case here.
  3. SHOULD_RETRY is pretty vague; if we do add an option, it should be unambiguous.

@abdullahwaheed
Copy link
Contributor

Hi @adeelkhan! This PR is inactive for quite a time now, could you please resolve the conversation and update your PR

@adeelkhan adeelkhan closed this Nov 5, 2023
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2023
@openedx-webhooks
Copy link

Although this pull request is already closed, I'm still watching it for updates.

There is nothing you have to do. No action is needed from your side. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants