From dacfbaef1cd13a78d69618b2d1f861e6aff74afb Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Mon, 26 Aug 2024 15:13:40 +0500
Subject: [PATCH 1/2] test: Add Node 20 to CI matrix

---
 .github/workflows/ci.yml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 26ab8e433..af70ed04c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -3,17 +3,19 @@ on: [push, pull_request]
 jobs:
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        node: [18, 20]
+    continue-on-error: ${{ matrix.node == 20 }}
     steps:
     - name: Checkout
       uses: actions/checkout@v2
       with:
         fetch-depth: 0
-    - name: Setup Nodejs Env
-      run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
     - name: Setup Nodejs
-      uses: dcodeIO/setup-node-nvm@v4
-      with:
-        node-version: "${{ env.NODE_VER }}"
+      uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node }}
     - name: Install dependencies
       run: npm ci
     - name: Validate package-lock.json changes

From f8c092cd350b99803ad82f6e792f35e1f1b46805 Mon Sep 17 00:00:00 2001
From: Bilal Qamar <59555732+BilalQamar95@users.noreply.github.com>
Date: Mon, 26 Aug 2024 17:07:11 +0500
Subject: [PATCH 2/2] refactor: adjusted workflow linespace

---
 .github/workflows/ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index af70ed04c..f4ff908f6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -14,8 +14,8 @@ jobs:
         fetch-depth: 0
     - name: Setup Nodejs
       uses: actions/setup-node@v4
-        with:
-          node-version: ${{ matrix.node }}
+      with:
+        node-version: ${{ matrix.node }}
     - name: Install dependencies
       run: npm ci
     - name: Validate package-lock.json changes