Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rtl support to editor #424

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ihor-romaniuk
Copy link
Contributor

TL;DR -

This pull request contains feature of dynamically adaptation to RLT or LTR side direction.

What changed?

Before After
image image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 24, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 24, 2023

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ihor-romaniuk ihor-romaniuk requested review from KristinAoki, connorhaugh and muselesscreator and removed request for connorhaugh November 24, 2023 16:20
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (57042c9) to head (c32f30e).
Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #424   +/-   ##
=======================================
  Coverage   90.55%   90.56%           
=======================================
  Files         227      227           
  Lines        4120     4122    +2     
  Branches      831      832    +1     
=======================================
+ Hits         3731     3733    +2     
  Misses        369      369           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @ihor-romaniuk! Just flagging that some branch conflicts have popped up.

@ihor-romaniuk
Copy link
Contributor Author

Hi @mphilbrick211! Resolved, thanks.

@mphilbrick211
Copy link

@openedx/teaching-and-learning this is all set for review!

@mphilbrick211 mphilbrick211 requested a review from a team December 13, 2023 20:45
@mphilbrick211
Copy link

@openedx/2u-tnl - would someone be able to please review / merge this for us?

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@mphilbrick211 mphilbrick211 requested review from a team and removed request for muselesscreator March 21, 2024 01:39
@mphilbrick211
Copy link

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks!

@mphilbrick211 mphilbrick211 removed request for connorhaugh and a team July 30, 2024 20:58
@mphilbrick211 mphilbrick211 added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jul 30, 2024
@KristinAoki KristinAoki merged commit ce87037 into openedx:main Aug 1, 2024
6 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@ihor-romaniuk ihor-romaniuk deleted the fix/add-rtl-support-to-editor branch August 20, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants