-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump shared eslint config version #565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I tested this in frontend-platform and frontend-app-course-authoring. After this bump, it stopped showing globalThis
as an eslint error.
BTW, something I mentioned to @davidjoy recently: I don't understand why we even have And according to npm, it's only used by |
The ESLint config in
According to the |
🎉 This PR is included in version 14.0.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 15.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I see now. Thanks for the context on that, @adamstankiewicz ! |
The shared
@edx/eslint-config
was recently updated to support thees2020
environment such that syntax likeglobalThis
won't cause linting errors.This PR bumps the version of
@edx/eslint-config
to pull in this change for consuming MFEs and shared JS libraries (e.g., frontend-platform).