fix: Exclude openedx scoped packages. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. |
We are moving packages to the `openedx` scope but those packages will also not be transpiled and we'll need to handle them in the same way. Marking this as a fix because we want to release a new version with this exclusion before we start moving more packages to the new scope.
feanil
force-pushed
the
feanil/exclude_openedx
branch
from
00c1af9 to
3c4ed9a
Compare
feanil
changed the title
brian-smith-tcril
approved these changes
Oct 31, 2023
abdullahwaheed
approved these changes
Nov 1, 2023
|
🎉 This PR is included in version 13.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
feanil
added a commit
to openedx/edx-ora2
that referenced
this pull request
Nov 1, 2023
Update to the latest frontend-build to pull in some webpack config updates (openedx/frontend-build#475). This necessitated an update to Webpack which was out of date, which in-turn resulted in an update to `karma-webpack`. I pulled in the latest changes and dealt with the one breaking change to karma config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving packages to the
openedxscope but those packages willalso not be transpiled and we'll need to handle them in the same way.
Marking this as a fix because we want to release a new version with this
exclusion before we start moving more packages to the new scope.