-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Oep65: Add Piral and Pilet webpack configuration #436
Conversation
Thanks for the pull request, @pedromartello! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
Hi @pedromartello, thank you for this contribution! Please let us know when the changes are ready for review and you've had a chance to submit a signed Contributor Agreement. |
@itsjeyd - the change is ready for review. I have sorted out the CLA check. Thank you. |
@pedromartello Great, thanks for the update! Hey @abdullahwaheed, this PR is ready for engineering review by fed-bom now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working with Pedro on this, so while I'm approving it as frontend core-contributor, we totally want a second opinion before merging.
/** | ||
* This webpack config is derived from the OpenEdx prod webpack config and is | ||
* used to bundle the Open Edx pilets. It removes the ReactRefreshWebpackPlugin | ||
* as it was conflicting with Piral during bundling. It als remoes the HTMLWebpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* as it was conflicting with Piral during bundling. It als remoes the HTMLWebpack | |
* as it was conflicting with Piral during bundling. It also removes the HTMLWebpack |
Upon further discussion with @arbrandes we will try a different route by manipulation the configs directly in the projects that consume them. This PR is therefore moved back into Draft until OEP65 is on more solid foooting. |
Hey @pedromartello, just checking in to see if this PR is still blocked? |
@pedromartello Friendly ping on this. And if this PR is indeed still blocked, do you know when it could potentially be unblocked? |
Hey @pedromartello, What is the current status of this PR, is it ready to review and merge? |
I am closing this pull request. The work has been incorporated into the piral project for now. We will open a new PR once the project is further along and warrants seeding configuration in frontend-build. |
@pedromartello Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@pedromartello Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This commit adds webpack configurations to support projects being built under OEP-65 (currently still OEP-XXXX). The OEP adds support for Piral to the open-edX frontend.
The
webpack.piral.config.js
is derived fromwebpack.dev.config.js
but removes babel, css and image modules and their configurations as well as the HtmlWebpackPlugin and the devServer (the equivalent functions are handled internally by piral). It is intended to be used with thefrontend-app-shell
package. The shell requires minimal configuration.The
webpack.pilet.config.js
is derived fromwebpack.prod.config.js
though it is intended for use indevelopment
mode currently. It removes bundle analyzer and adds support for typescript. It also removes the HtmlWebpackPlugin as the piral framework handles that internally. It is intended to be used with future builds of MFE projects being converted toPilets
(see Piral.io link above) to be loaded in thefrontend-app-shell
referenced above.