Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Oep65: Add Piral and Pilet webpack configuration #436

Closed
wants to merge 1 commit into from

Conversation

pedromartello
Copy link

This commit adds webpack configurations to support projects being built under OEP-65 (currently still OEP-XXXX). The OEP adds support for Piral to the open-edX frontend.

The webpack.piral.config.js is derived from webpack.dev.config.js but removes babel, css and image modules and their configurations as well as the HtmlWebpackPlugin and the devServer (the equivalent functions are handled internally by piral). It is intended to be used with the frontend-app-shell package. The shell requires minimal configuration.

The webpack.pilet.config.js is derived from webpack.prod.config.js though it is intended for use in development mode currently. It removes bundle analyzer and adds support for typescript. It also removes the HtmlWebpackPlugin as the piral framework handles that internally. It is intended to be used with future builds of MFE projects being converted to Pilets (see Piral.io link above) to be loaded in the frontend-app-shell referenced above.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 9, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 9, 2023

Thanks for the pull request, @pedromartello! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@pedromartello pedromartello changed the title feat: Oep65 - Add Piral and Pilet webpack configs feat: Oep65 - Add Piral and Pilet webpack configuration Aug 9, 2023
@e0d e0d changed the title feat: Oep65 - Add Piral and Pilet webpack configuration feat: Oep65 - Add Piral and Pilet webpack configuration Aug 9, 2023
@e0d e0d changed the title feat: Oep65 - Add Piral and Pilet webpack configuration feat: Oep65 - Add Piral and Pilet webpack configuration Aug 9, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 15, 2023

Hi @pedromartello, thank you for this contribution!

Please let us know when the changes are ready for review and you've had a chance to submit a signed Contributor Agreement.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 15, 2023
@pedromartello pedromartello changed the title feat: Oep65 - Add Piral and Pilet webpack configuration feat: Oep65: Add Piral and Pilet webpack configuration Aug 18, 2023
@pedromartello pedromartello marked this pull request as ready for review August 18, 2023 13:12
@pedromartello
Copy link
Author

Hi @pedromartello, thank you for this contribution!

Please let us know when the changes are ready for review and you've had a chance to submit a signed Contributor Agreement.

@itsjeyd - the change is ready for review. I have sorted out the CLA check. Thank you.

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 22, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 22, 2023

@pedromartello Great, thanks for the update!

Hey @abdullahwaheed, this PR is ready for engineering review by fed-bom now.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been working with Pedro on this, so while I'm approving it as frontend core-contributor, we totally want a second opinion before merging.

/**
* This webpack config is derived from the OpenEdx prod webpack config and is
* used to bundle the Open Edx pilets. It removes the ReactRefreshWebpackPlugin
* as it was conflicting with Piral during bundling. It als remoes the HTMLWebpack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* as it was conflicting with Piral during bundling. It als remoes the HTMLWebpack
* as it was conflicting with Piral during bundling. It also removes the HTMLWebpack

@arbrandes arbrandes marked this pull request as draft August 24, 2023 19:03
@pedromartello
Copy link
Author

Upon further discussion with @arbrandes we will try a different route by manipulation the configs directly in the projects that consume them. This PR is therefore moved back into Draft until OEP65 is on more solid foooting.

@itsjeyd itsjeyd added blocked by other work PR cannot be finished until other work is complete and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Sep 13, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 10, 2023

Hey @pedromartello, just checking in to see if this PR is still blocked?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 17, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 8, 2023

@pedromartello Friendly ping on this. And if this PR is indeed still blocked, do you know when it could potentially be unblocked?

@Mashal-m
Copy link
Contributor

Hey @pedromartello, What is the current status of this PR, is it ready to review and merge?

@pedromartello
Copy link
Author

I am closing this pull request. The work has been incorporated into the piral project for now. We will open a new PR once the project is further along and warrants seeding configuration in frontend-build.

@openedx-webhooks
Copy link

@pedromartello Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@pedromartello Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by other work PR cannot be finished until other work is complete open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants