Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Remove CTA #360

Closed
asadali145 opened this issue Oct 1, 2024 · 5 comments
Closed

[DEPR]: Remove CTA #360

asadali145 opened this issue Oct 1, 2024 · 5 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@asadali145
Copy link
Contributor

asadali145 commented Oct 1, 2024

Proposal Date

2024-10-01

Target Ticket Acceptance Date

2024-10-15

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04

Rationale

CTA was added 2 years ago and it has served the purpose. We can safely remove it.

CTA is always visible and there is no way to hide/disable it.

Removal

The following will be removed:

  • CTA and respective usage.

Replacement

None

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

No response

@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Oct 1, 2024
@awais-ansari
Copy link
Contributor

@asadali145, We are still using the Notifications banner to inform learners about newly available ORA-related notification preferences. Thanks

@asadali145 asadali145 changed the title [DEPR]: Remove CTA and Notification Banner [DEPR]: Remove CTA Oct 2, 2024
@asadali145
Copy link
Contributor Author

Thanks @awais-ansari, I have updated the ticket to remove the CTA.

@asadali145
Copy link
Contributor Author

@brian-smith-tcril Did you get a chance to look into this DEPR ticket?

@brian-smith-tcril
Copy link
Contributor

We're going to remove this because we shouldn't have links to org specific resources (in this case a google form) in the platform.
@awais-ansari If this functionality is needed a frontend-plugin-framework slot should be added and the banners can be created as plugins that can be put into the slot.

@brian-smith-tcril brian-smith-tcril moved this from Proposed to Accepted in DEPR: Deprecation & Removal Nov 1, 2024
@feanil
Copy link
Contributor

feanil commented Nov 7, 2024

This was completed via #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Removed
Development

No branches or pull requests

4 participants