Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock icon in courseware sidebar does not follow conventions for notifications #1509

Open
aphilipharrell opened this issue Oct 30, 2024 · 5 comments
Assignees

Comments

@aphilipharrell
Copy link

The clock icon in the courseware sidebar leads to a Notifications window - the clock icon is misleading and this should be replaced with something more commonly understood to represent notifications.

Suggested fix:

Replace WatchOutline with Notifications in src/courseware/course/sidebar/sidebars/notifications/NotificationIcon.jsx

@jciasenza
Copy link
Contributor

@arbrandes
I assign it to myself

@jciasenza
Copy link
Contributor

jciasenza commented Nov 1, 2024

Hello aphilipharrell, I already made the PR

#1510

@angonz
Copy link

angonz commented Nov 8, 2024

@crathbun428 Can you please check if this request can be implemented? We can do it if approved.

@crathbun428
Copy link

crathbun428 commented Nov 20, 2024

@angonz - There is potentially going to be some work done on the right-sidebar soon. I think thinking through what icons are shown will be apart of this work. I want to check in with @brian-smith-tcril and @jmakowski1123 to make sure I have this right.

@itsjeyd
Copy link

itsjeyd commented Dec 19, 2024

Hi @aphilipharrell, just a heads-up that we ended up closing #1510 because it looked like someone had already made the same changes for Sumac.

So you might want to consider closing this issue, too.

CC @jciasenza @crathbun428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants