Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle rtl/ltr for hangouts #1192

Conversation

Inferato
Copy link

For some reason, Handouts didn't match the direction when RTL/LTR lang was chosen

@openedx-webhooks
Copy link

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 21, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 10, 2023

Hi @Inferato, thank you for this contribution! Are you planning to continue working on the changes? If not, we'll line them up for a test run next.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 10, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 24, 2023

@Inferato All tests are green so I'm assuming that this PR is ready for review.

@mattcarter @openedx/content-aurora This is ready for engineering review by Aurora.

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 24, 2023
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mattcarter mattcarter merged commit 0e98399 into openedx:open-release/palm.master Nov 13, 2023
@openedx-webhooks
Copy link

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
vunguyen-dmt added a commit to vunguyen-dmt/frontend-app-learning that referenced this pull request Nov 20, 2023
fix: [RGOeX-25901] Handle rtl/ltr for hangouts (openedx#1192)
This was referenced Feb 9, 2024
@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants