Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some problems with drag and drop functionality #851

Closed
PKulkoRaccoonGang opened this issue Feb 22, 2024 · 2 comments · Fixed by #859
Closed

Some problems with drag and drop functionality #851

PKulkoRaccoonGang opened this issue Feb 22, 2024 · 2 comments · Fixed by #859
Assignees
Labels
bug Report of or fix for something that isn't working as intended

Comments

@PKulkoRaccoonGang
Copy link
Contributor

In the current implementation of the Course outline page, we have the previously added drag-and-drop functionality for sections, sub-sections, and course units. Technically, this functionality is based on two @edx/frontend-lib-content-components repository components: SortableItem and DraggableList.

Screen.Recording.2024-02-22.at.12.25.41.mov

In the video attached below you can notice problems with the visual display of the dragged component, specifically:

  1. Floating position of the "Drag to reorder" tooltip. The tooltip is displayed during hover (or focus on draggable button)
  2. Available to drag an element beyond the boundaries of the page container (under or above neighboring elements)
  3. Visual distortion of the dragged element
  4. There is no high level of z-index (the dragged element may be hidden under other elements on the page)

The drag-and-drop functionality is now being used for the new Сourse unit page (under development). It makes sense to carry out optimizations and corrections in @edx/frontend-lib-content-components to improve performance and user experience for the Course outline and Course unit pages of the current repository frontend-app-course-authoring

@PKulkoRaccoonGang PKulkoRaccoonGang added the bug Report of or fix for something that isn't working as intended label Feb 22, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title Some problems with drag and drop functionality [bug]: Some problems with drag and drop functionality Feb 22, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [bug]: Some problems with drag and drop functionality Some problems with drag and drop functionality Feb 22, 2024
@navinkarkera
Copy link
Contributor

I am working on fixing it, will post details later on.

@navinkarkera navinkarkera self-assigned this Feb 23, 2024
@navinkarkera
Copy link
Contributor

Should be fixed by #859.

The drag-and-drop functionality is now being used for the new Сourse unit page (under development). It makes sense to carry out optimizations and corrections in @edx/frontend-lib-content-components to improve performance and user experience for the Course outline and Course unit pages of the current repository frontend-app-course-authoring

We cannot really use generic dragging components from frontend-lib-content-components as here blocks need to move across different parent blocks which requires a lot of custom functionality as seen in #859 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

2 participants