feat: add support for es2020 syntax in shared eslint config
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
force-pushed
the
ags/es2020-env
branch
from
5856451 to
4b250fb
Compare
adamstankiewicz
changed the title
es2020 syntax in eslintes2020 syntax in shared eslint config
bradenmacdonald
approved these changes
Jun 20, 2024
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this comment thread, this PR adds support for
es2020syntax. The primary rationale is that given we are to beginning to supportglobalThissyntax in shared JS libraries and MFEs, we should ensure other related ES2020 syntax is included as well, and implemented in such a way that is common/applicable as opposed to being added to individual ESLint configs. The Open edX platform officially supports the browsers defined in@edx/browserslist-config(source), where all have support fores2020syntax.