Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restricted runs can be marketable and that's fine #997

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: restricted runs can be marketable and that's fine #997

merged 1 commit into from
Nov 14, 2024

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Nov 14, 2024 •
edited
Loading

We had previously assumed that restricted course runs could be marked with is_marketable=False but still expected to be marketable to enterprise learners in some circumstances; this assumption was incorrect.

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

@iloveagent57 iloveagent57 merged commit ddda318 into master Nov 14, 2024
4 checks passed
@iloveagent57 iloveagent57 deleted the aed/fix-v2-active-logic branch November 14, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macdiesel macdiesel macdiesel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iloveagent57 @macdiesel