Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restricted runs to be considered conditionally active #987

Closed
wants to merge 1 commit into from

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Oct 23, 2024

Restricted course run records will be set with is_marketable: false from the upstream source-of-truth (course-discovery). But because our discovery <-> catalog synchronization has business logic that filters course run json metadata (inside of courses) to only the allowed restricted runs for a catalog, we can safely assume when looking at a course run metadata record in the context of a catalog, if that run has a non-null, B2B restriction type, then it is permitted to be part of the catalog and should be considered active (as long as it is published and enrollable).

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant