build: fixes for native deployment #407
Conversation
When deploying enterprise-access using a playbook based on the edx_django_service role, the production requirements fail to install due to missing pip-tools. This commit makes the production-requirements command depend on `piptools` so that pip-tools are installed before installing the production requirements.
Pygments is directly imported in enterprise_access/app/subsidy_access_pilicy/admin.py. But it is not included a base dependency. This commit adds it as a base dependency and updates all the requirements using `make upgrade`.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
LGTM. FWIW, in production for edx.org we don't actually rely on this make target to install requirements. We use the pip sequence in the Dockerfile
Line 81 in 40e699d
|
@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@pwnage101 Thank you for the quick review and merge. |
While creating the Ansible playbooks and roles for deploying enterprise-access - openedx-unsupported/configuration#7107, a couple of issues were discovered with the
production-requirementsmake command and the requirements.This PR includes the following changes:
production-requriementscommand depend on thepiptoolscommand so that it can be run without explicitly running thepiptoolsbeforehand.pygmentsas an explicit requirement.