feat: new "retired" field on policy models #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-8206-2
branch
2 times, most recently
from
f9fd781 to
a403ebd
Compare
pwnage101
commented
Jan 16, 2024
Comment on lines
1300
to
1304
| # The following policy should never be returned as it has redeemability disabled. | ||
| PerLearnerEnrollmentCapLearnerCreditAccessPolicyFactory( | ||
| enterprise_customer_uuid=self.enterprise_uuid, | ||
| redeemability_disabled_at=datetime.utcnow() - timedelta(days=1), | ||
| ) |
There was a problem hiding this comment.
As discussed at standup on Friday, when redeemability is disabled (was: policy is "retired"), we should make the policy effectively disappear from a learner's perspective. I.e. it should not be returned by the credits_available endpoint, tested here.
brobro10000
approved these changes
Jan 16, 2024
pwnage101
force-pushed
the
pwnage101/ENT-8206-2
branch
2 times, most recently
from
ee2f5a0 to
e0bd1e3
Compare
Implements ADR 0016-policy-retirement, and also updates it to reflect the decision to rename the field to "retired" and change it to a boolean. Note this also adds extra visibility into the historical values of various policy fields via the django admin record history interface. Previously, changes were only noted (e.g. "active field changed"), but now the actual historical value of the field is visible. ENT-8206
pwnage101
force-pushed
the
pwnage101/ENT-8206-2
branch
from
e0bd1e3 to
a96819a
Compare
|
Forced pushed changes:
Example of the history page for a policy that I changed to retired: |
pwnage101
changed the title
iloveagent57
approved these changes
Jan 18, 2024
| with the customer uuid requested by the client. | ||
| """ | ||
| return SubsidyAccessPolicy.objects.filter( | ||
| return SubsidyAccessPolicy.policies_with_redemption_enabled().filter( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ADR 0016-policy-retirement, and also updates it to reflect
the decision to rename the field to "retired" and change it to a
boolean.
Note this also adds extra visibility into the historical values of
various policy fields via the django admin record history interface.
Previously, changes were only noted (e.g. "active field changed"), but
now the actual historical value of the field is visible.
ENT-8206
Screenshots
What the checkboxes look like in django admin edit page for a policy.
Example of the history page for a policy that I changed to retired:
