Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Try to populate lms_user_id on assignments during creation #308

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

pwnage101
Copy link
Contributor

This is an attempt to cover the case where learners are already logged in at the moment of assignment. This case is a hole left by the work in ENT-7875 which only set out to cover the case where a learner was logged out at the moment of assignment.

ENT-7874

@pwnage101 pwnage101 force-pushed the pwnage101/ENT-7874 branch 2 times, most recently from c3b3036 to 691583f Compare November 1, 2023 07:31
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, two non-blocking nits!

enterprise_access/apps/content_assignments/api.py Outdated Show resolved Hide resolved
enterprise_access/apps/content_assignments/api.py Outdated Show resolved Hide resolved
enterprise_access/apps/content_assignments/api.py Outdated Show resolved Hide resolved
@iloveagent57
Copy link
Contributor

well, plus I guess also the tests :)

@pwnage101 pwnage101 force-pushed the pwnage101/ENT-7874 branch 4 times, most recently from 5f9f0e1 to f075a40 Compare November 3, 2023 05:55
@pwnage101 pwnage101 marked this pull request as ready for review November 3, 2023 05:55
This is an attempt to cover the case where learners are already
logged in at the moment of assignment.  This case is a hole left by the
work in ENT-7875 which only set out to cover the case where a learner
was logged out at the moment of assignment.

ENT-7874
@pwnage101 pwnage101 merged commit fbdda0a into main Nov 4, 2023
3 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-7874 branch November 4, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants