Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added assignments in credits_available endpoint #307

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

irfanuddinahmad
Copy link
Contributor

@irfanuddinahmad irfanuddinahmad commented Oct 26, 2023

Description: This PR adds the learner content assignments to the credits_available endpoint

JIRA : ENT-7870

Sample Output

image

@irfanuddinahmad irfanuddinahmad changed the title feat: Added assignments in credits_available endpoint WIP: feat: Added assignments in credits_available endpoint Oct 26, 2023
@irfanuddinahmad irfanuddinahmad force-pushed the iahmad/ENT-7870 branch 9 times, most recently from 0c346af to 7778432 Compare October 31, 2023 17:39
@irfanuddinahmad irfanuddinahmad changed the title WIP: feat: Added assignments in credits_available endpoint feat: Added assignments in credits_available endpoint Oct 31, 2023
Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the response details in the PR description. Other than that LGTM 👍

Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more unit test request, then this is good to go!

@irfanuddinahmad
Copy link
Contributor Author

One more unit test request, then this is good to go!

@iloveagent57 Could I request a re-review and merge (if all ok)?

@iloveagent57 iloveagent57 merged commit 5de1c4e into main Nov 6, 2023
3 checks passed
@iloveagent57 iloveagent57 deleted the iahmad/ENT-7870 branch November 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants