Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AU-2283): Create transcript delete endpoint #541

Merged
merged 9 commits into from
Dec 2, 2024
Merged

Conversation

Rodra
Copy link
Contributor

@Rodra Rodra commented Nov 18, 2024

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.56%. Comparing base (11521db) to head (acd96d3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
edxval/views.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   94.52%   94.56%   +0.03%     
==========================================
  Files          31       31              
  Lines        3106     3165      +59     
  Branches      120      122       +2     
==========================================
+ Hits         2936     2993      +57     
- Misses        152      154       +2     
  Partials       18       18              
Flag Coverage Δ
unittests 94.56% <96.72%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edxval/views.py Outdated Show resolved Hide resolved
edxval/views.py Outdated Show resolved Hide resolved
edxval/views.py Outdated Show resolved Hide resolved
@BrandonHBodine
Copy link
Member

What kind of permission does a user need to have to hit this endpoint?

Copy link
Member

@BrandonHBodine BrandonHBodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so we don't open this endpoint up to non staff or non course authors.

@BrandonHBodine BrandonHBodine changed the title feat(AU-2283): Create transcript bulk delete endpoint feat(AU-2283): Create transcript delete endpoint Nov 26, 2024
@Rodra Rodra merged commit b154484 into master Dec 2, 2024
8 checks passed
@Rodra Rodra deleted the feat/AU-2283 branch December 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants