Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoint to fetch course video ids #461

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

hajorg
Copy link
Contributor

@hajorg hajorg commented Oct 4, 2023

Summary

This PR creates an endpoint to fetch video IDs for a course.

@hajorg hajorg force-pushed the hajorg/add-course-video-ids-endpoint branch from e271ec6 to 2980772 Compare October 4, 2023 17:24
@hajorg hajorg force-pushed the hajorg/add-course-video-ids-endpoint branch from 2980772 to 182b1fc Compare October 4, 2023 17:25
Copy link
Member

@BrandonHBodine BrandonHBodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0a85bb8) 94.42% compared to head (c61a74b) 94.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   94.42%   94.47%   +0.04%     
==========================================
  Files          28       28              
  Lines        3051     3076      +25     
  Branches      171      172       +1     
==========================================
+ Hits         2881     2906      +25     
  Misses        151      151              
  Partials       19       19              
Flag Coverage Δ
unittests 94.47% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
edxval/__init__.py 100.00% <100.00%> (ø)
edxval/api.py 93.80% <100.00%> (+0.06%) ⬆️
edxval/tests/test_api.py 99.82% <100.00%> (+<0.01%) ⬆️
edxval/tests/test_views.py 100.00% <100.00%> (ø)
edxval/urls.py 57.14% <ø> (ø)
edxval/views.py 93.46% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hajorg hajorg force-pushed the hajorg/add-course-video-ids-endpoint branch from 9265b80 to 03f11c2 Compare October 5, 2023 14:35
@hajorg hajorg merged commit ccec7ad into master Oct 5, 2023
8 checks passed
@hajorg hajorg deleted the hajorg/add-course-video-ids-endpoint branch October 5, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants