Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add PII annotations #273

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Nov 25, 2024

Per OEP-30 these annotations belong with their models, I'm just moving them from the edx-platform safelist to their correct homes.

Per OEP-30 these annotations belong with their models, I'm just moving
them from the edx-platform safelist to their correct homes.
@bmtcril bmtcril requested a review from pomegranited November 25, 2024 20:09
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (43d4f3b) to head (1908b9f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          18       18           
  Lines        1995     1995           
  Branches       90       90           
=======================================
  Hits         1866     1866           
  Misses        118      118           
  Partials       11       11           
Flag Coverage Δ
unittests 93.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @bmtcril :)

  • I tested this docs update only
  • I read through the code and checked the annotated models for PII
  • Updates documentation

@pomegranited pomegranited merged commit 7230124 into openedx:master Dec 10, 2024
24 checks passed
@bmtcril bmtcril deleted the bmtcril/pii_annotations branch December 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants