From 372c567acc4a9c6f07c8ea49519ad24bb4042092 Mon Sep 17 00:00:00 2001 From: Deborah Kaplan Date: Thu, 6 Jun 2024 19:36:15 +0000 Subject: [PATCH 1/2] feat: temporarily prevent renovate from updating this package Minor (and therefore presumed-safe by renovate) version updates caused an exception on some deprecated code. Marking this package as not-safe for renovate until that code is removed, which will happen quite soon. see external (2U) ticket REV-4067 for details. cc @julianajlk FIXES: APER-3502 --- .github/renovate.json | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/renovate.json b/.github/renovate.json index a644bd656c7e..66f46a748162 100644 --- a/.github/renovate.json +++ b/.github/renovate.json @@ -28,6 +28,7 @@ "automerge": true } ], + "ignoreDeps": ["moment-timezone"], "timezone": "America/New_York", "prConcurrentLimit": 3, "enabledManagers": ["npm"] From b72033b4a9e828d62bef96e670a347b23447f73f Mon Sep 17 00:00:00 2001 From: Deborah Kaplan Date: Thu, 6 Jun 2024 16:02:24 -0400 Subject: [PATCH 2/2] feat: adding a comment attempting to add a comment explaining the ignored dependency Co-authored-by: Kyle McCormick --- .github/renovate.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/renovate.json b/.github/renovate.json index 66f46a748162..a0ee80098567 100644 --- a/.github/renovate.json +++ b/.github/renovate.json @@ -29,6 +29,10 @@ } ], "ignoreDeps": ["moment-timezone"], + "__Open_edX_ignoreDeps_reasons__": { + "__note__": "When you add a package to ignoreDeps, add a comment to this object, using the package name as the key, and the comment as the value.", + "moment-timezone": "Broke legacy programs dashboard, which is deprecated and soon to be removed. See https://github.com/openedx/edx-platform/pull/34928" + }, "timezone": "America/New_York", "prConcurrentLimit": 3, "enabledManagers": ["npm"]