Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore Courses button doesn't follow the same style conventions of MFE header #35836

Open
aphilipharrell opened this issue Nov 13, 2024 · 1 comment
Open

Explore Courses button doesn't follow the same style conventions of MFE header #35836

aphilipharrell opened this issue Nov 13, 2024 · 1 comment

Comments

@aphilipharrell
Copy link

The links in the navigation do not follow conventions for action links. These should have a hover state similar to the navigation bar in MFEs which underline when hovered over.

edx-platform/lms/templates/header/navbar-not-authenticated.html

Line 42 in 15aa04b

<a href="/courses">${_('Explore courses')}</a>

@jciasenza
Copy link

jciasenza commented Dec 9, 2024 •
edited
Loading

I made PR #35994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aphilipharrell @jciasenza