Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the PEP 508 format without editable VCS requirements #35654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MoisesGSalas
Copy link

@MoisesGSalas MoisesGSalas commented Oct 15, 2024

Description

This change makes it possible to use uv as a pip replacement in order to perform a faster installation of requirements.

edx_proctoring_proctortrack already publishes to PyPI (although the release with Django 4.2 support has not been published), so we don't need to install the package as editable because the MANIFEST.in file already includes all the necessary extra files.

There was also the possibility of removing the package altogether, maybe we can make that push for the Sumak release?

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 15, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 15, 2024

Thanks for the pull request, @MoisesGSalas!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@MoisesGSalas MoisesGSalas marked this pull request as ready for review October 16, 2024 20:01
@MoisesGSalas MoisesGSalas requested a review from a team as a code owner October 16, 2024 20:01
@MoisesGSalas MoisesGSalas force-pushed the mgs/use-pep508-format branch from 3642cab to 12a1963 Compare October 17, 2024 16:09
@mphilbrick211
Copy link

@MoisesGSalas - hi there! Flagging that an additional test has popped up that needs to be run.

@openedx/2u-arbi-bom flagging for review.

This change makes it possible to use [uv](https://github.com/astral-sh/uv)
as a pip replacement in order to perform a faster installation of
requirements.

`edx_proctoring_proctortrack` already publishes to PyPI (although the
release with Django 4.2 support has not been published), so we don't
need to install the package as editable because the MANIFEST.in file
already includes all the necessary extra files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants