-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a POST endpoint for listing courses #35586
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @viadanna! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @viadanna! Looks like a few additional tests popped up. Can you see if you can run them? |
Sure thing, done @mphilbrick211 |
Apologies, @viadanna - but there's an additional test that needs to be run. Thank you for your patience. I've put this pull request out to our Core Contributors for review. |
Description
This pull request introduces functionality to filter courses using a POST request in the course API. The reason for this is to be able to able to use a filter larger than allowed in GET query params.
The key changes include adding a new test for POST request filtering, modifying the
get_queryset
method to handle POST data, and adding a POST method to the view.Testing instructions
/api/courses/v1/courses/
to query for courses.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.