Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let the platform decide to how login the users #34995

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodeWithEmad
Copy link
Member

We force users to go to authentication mfe for login/registration and prevent login behavior tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirects users to a TPA when they visit /login.

Close #34990

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 14, 2024

Thanks for the pull request, @CodeWithEmad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 14, 2024
@CodeWithEmad CodeWithEmad force-pushed the fix/logistration-flow branch from 99234eb to fdd3f86 Compare June 14, 2024 15:38
@CodeWithEmad
Copy link
Member Author

Any idea?
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

@mphilbrick211
Copy link

Any idea? Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Hi @CodeWithEmad! If needed, I can see if someone on the Axim team can help with this.

@CodeWithEmad
Copy link
Member Author

@mphilbrick211 That would be amazing. Thank you.

We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks l
ike having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.
@CodeWithEmad CodeWithEmad force-pushed the fix/logistration-flow branch from fdd3f86 to d9ac1da Compare June 21, 2024 13:58
@pdpinch
Copy link
Contributor

pdpinch commented Oct 13, 2024

How is this different from using the setting ENABLE_REQUIRE_THIRD_PARTY_AUTH?

https://docs.openedx.org/projects/edx-platform/en/latest/references/featuretoggles.html#featuretoggle-ENABLE_REQUIRE_THIRD_PARTY_AUTH

I feel like there is a subtle difference, but I'm not sure.

@CodeWithEmad
Copy link
Member Author

Thanks for mentioning this. My change is related to the old theme, where it forces you to first go to the authn mfe if you have it enabled, no matter what. then, from there, it chooses to send you to either third-party authentication or not. the login URL will redirect you to the current address anyway. I hope it makes sense.

@mphilbrick211
Copy link

Hi @CodeWithEmad! Just flagging a new test has popped up. Then it looks like this can be reviewed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

Let the platform login control user login/register flow
4 participants