-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: let the platform decide to how login the users #34995
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @CodeWithEmad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
99234eb
to
fdd3f86
Compare
Any idea? |
Hi @CodeWithEmad! If needed, I can see if someone on the Axim team can help with this. |
@mphilbrick211 That would be amazing. Thank you. |
We force users to go to authentication mfe for login/registration and prevent the login behaviour tweaks l ike having THIRD_PARTY_AUTH_HINT in your site configuration which redirect users to a TPA when they visit /login.
fdd3f86
to
d9ac1da
Compare
How is this different from using the setting I feel like there is a subtle difference, but I'm not sure. |
Thanks for mentioning this. My change is related to the old theme, where it forces you to first go to the |
Hi @CodeWithEmad! Just flagging a new test has popped up. Then it looks like this can be reviewed again. |
We force users to go to authentication mfe for login/registration and prevent login behavior tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirects users to a TPA when they visit /login.
Close #34990