You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
because they don't realize that lint-amnesty has a special meaning (that is: pylint violations which were grandfathered in because they were introduced before we enforced linting).
If we want lint-amnesty to continue to mean something, then we need to add a check that will hard-code a maximum number of lint-amnesty comments and fail CI if any more area added.
Alternatively, we call it a wash and blanket replace every occurance of lint-amnesty, pylint: with pylint:
The text was updated successfully, but these errors were encountered:
Since there is no immediate plan of fixing all pending lint-amnesty warnings, I believe second approach should be more beneficial i.e. changing lint-amnesty, pylint: to just pylint: . Also, it'll be a more straight forward task than introducing a new check.
People are constantly adding:
instead of just:
because they don't realize that
lint-amnesty
has a special meaning (that is: pylint violations which were grandfathered in because they were introduced before we enforced linting).If we want
lint-amnesty
to continue to mean something, then we need to add a check that will hard-code a maximum number of lint-amnesty comments and fail CI if any more area added.Alternatively, we call it a wash and blanket replace every occurance of
lint-amnesty, pylint:
withpylint:
The text was updated successfully, but these errors were encountered: