fix: rename update cache functions to what they are #33550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashultz0
force-pushed
the
ashultz0/rename_second_update_enrollment
branch
from
8089b0f to
c3a24c1
Compare
deborahgu
approved these changes
Oct 20, 2023
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure rename refactor and the _update_enrollment token only appears one other place in platform code or other standard repos where it refers to a local function, so if it passes checks we're good.
I was documenting that _update_enrollment was not to be confused with update_enrollment and decided that was too shameful to write in a wiki when it could be trivially fixed.
While I'm at it, this is not updating an enrollment, it is updating an enrollment state which is much smaller, so let's be clear on that too.