-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: order in the view of the signatures in the certificate when choice print #32720
Conversation
Thanks for the pull request, @BetoFandino! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@BetoFandino we need to have a valid CLA in place for all contributions. Is this change being contributed by you as an individual or on behalf of your employer? |
@BetoFandino It looks like there are also some test failures. You can see the logs by following the "Details" link. |
Hello @e0d , yes it was on behalf of the company I work for called EduNEXT, as for the errors in the unitest it seems that I failed in the installation of the requirements. |
Hi @BetoFandino! Could you please check with your manager to see if you can be added to the eduNEXT entity CLA they have with us? Your manager can reach out to [email protected] with this request. |
@mphilbrick211: now we have a green check! |
Hi @openedx/2u-aperture! Would someone be able to review/merge this for us? Thanks! |
A Jira ticket was created in the Aperture internal board, and we'll be discussing this PR in the upcoming grooming session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BetoFandino, could you pull changes from master? There's an action fix preventing this from being merged, and if you bring in updates that should address it. |
@BetoFandino 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
In the palm environment an error was reported in the view of the certificates as it can be seen at the moment of printing it:
It was identified that the signature field at the time of printing the same ones were organized vertically, so a media print field was added to maintain the horizontal order when selecting print.
Supporting information
The problem was reported and consulted at the following link openedx/wg-build-test-release#274
Testing instructions
Add more than one signature and select the option to print the certificate.