Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order in the view of the signatures in the certificate when choice print #32720

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

BetoFandino
Copy link
Contributor

Description

In the palm environment an error was reported in the view of the certificates as it can be seen at the moment of printing it:
image

It was identified that the signature field at the time of printing the same ones were organized vertically, so a media print field was added to maintain the horizontal order when selecting print.
image

Supporting information

The problem was reported and consulted at the following link openedx/wg-build-test-release#274

Testing instructions

Add more than one signature and select the option to print the certificate.

@openedx-webhooks
Copy link

openedx-webhooks commented Jul 11, 2023

Thanks for the pull request, @BetoFandino! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 11, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 14, 2023
@e0d
Copy link
Contributor

e0d commented Jul 17, 2023

@BetoFandino we need to have a valid CLA in place for all contributions. Is this change being contributed by you as an individual or on behalf of your employer?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 17, 2023
@e0d
Copy link
Contributor

e0d commented Jul 17, 2023

@BetoFandino It looks like there are also some test failures. You can see the logs by following the "Details" link.

@BetoFandino
Copy link
Contributor Author

Hello @e0d , yes it was on behalf of the company I work for called EduNEXT, as for the errors in the unitest it seems that I failed in the installation of the requirements.

@mphilbrick211
Copy link

Hello @e0d , yes it was on behalf of the company I work for called EduNEXT, as for the errors in the unitest it seems that I failed in the installation of the requirements.

Hi @BetoFandino! Could you please check with your manager to see if you can be added to the eduNEXT entity CLA they have with us? Your manager can reach out to [email protected] with this request.

@mariajgrimaldi
Copy link
Member

@mphilbrick211: now we have a green check!

@mphilbrick211
Copy link

Hi @openedx/2u-aperture! Would someone be able to review/merge this for us? Thanks!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Aug 30, 2023
@jsnwesson
Copy link
Contributor

A Jira ticket was created in the Aperture internal board, and we'll be discussing this PR in the upcoming grooming session.

@deborahgu deborahgu requested review from deborahgu and removed request for hurtstotouchfire September 22, 2023 20:13
@deborahgu deborahgu self-assigned this Sep 22, 2023
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, although on firefox the signature block renders pretty wide:

certificate print view from Firefox with a signature block which stretches between the right and left margins

I am approving, but I don't want to merge on Friday afternoon, so will merge this next week.

@deborahgu deborahgu removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 26, 2023
@deborahgu
Copy link
Member

@BetoFandino, could you pull changes from master? There's an action fix preventing this from being merged, and if you bring in updates that should address it.

@deborahgu deborahgu removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Sep 26, 2023
@deborahgu deborahgu merged commit bbacdc8 into openedx:master Sep 26, 2023
@openedx-webhooks
Copy link

@BetoFandino 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants