From 4839b754674a2d2c44400b340ac2ec4a1383e547 Mon Sep 17 00:00:00 2001 From: "Kyle D. McCormick" Date: Tue, 3 Dec 2024 17:09:07 -0500 Subject: [PATCH] temp: disable broken test suites for Webpack-built JS Should be re-enabled in: https://github.com/openedx/edx-platform/issues/35956 --- pavelib/utils/envs.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/pavelib/utils/envs.py b/pavelib/utils/envs.py index d2cdd4a77d7a..7dc9870fbdea 100644 --- a/pavelib/utils/envs.py +++ b/pavelib/utils/envs.py @@ -88,15 +88,19 @@ class Env: KARMA_BROWSER = 'FirefoxNoUpdates' # Files used to run each of the js test suites - # TODO: Store this as a dict. Order seems to matter for some - # reason. See issue TE-415. + # TODO: We have [temporarily disabled] the three Webpack-based tests suites. They have been silently + # broken for a long time; after noticing they were broken, we added the DieHardPlugin to + # webpack.common.config.js to prevent future silent breakage, but have not yet been able to + # fix and re-enable the suites. Note that the LMS suite is all Webpack-based even though it's + # not in the name. + # Issue: https://github.com/openedx/edx-platform/issues/35956 KARMA_CONFIG_FILES = [ REPO_ROOT / 'cms/static/karma_cms.conf.js', REPO_ROOT / 'cms/static/karma_cms_squire.conf.js', - REPO_ROOT / 'cms/static/karma_cms_webpack.conf.js', - REPO_ROOT / 'lms/static/karma_lms.conf.js', + ## [temporarily disabled] REPO_ROOT / 'cms/static/karma_cms_webpack.conf.js', + ## [temporarily disabled] REPO_ROOT / 'lms/static/karma_lms.conf.js', REPO_ROOT / 'xmodule/js/karma_xmodule.conf.js', - REPO_ROOT / 'xmodule/js/karma_xmodule_webpack.conf.js', + ## [temporarily disabled] REPO_ROOT / 'xmodule/js/karma_xmodule_webpack.conf.js', REPO_ROOT / 'common/static/karma_common.conf.js', REPO_ROOT / 'common/static/karma_common_requirejs.conf.js', ] @@ -104,10 +108,10 @@ class Env: JS_TEST_ID_KEYS = [ 'cms', 'cms-squire', - 'cms-webpack', - 'lms', + ## [temporarily-disabled] 'cms-webpack', + ## [temporarily-disabled] 'lms', 'xmodule', - 'xmodule-webpack', + ## [temporarily-disabled] 'xmodule-webpack', 'common', 'common-requirejs', 'jest-snapshot'