Skip to content

Commit

Permalink
build: remove unused libsass dependency (#1987)
Browse files Browse the repository at this point in the history
(Bumps version: 5.1.1 -> 5.2.0)

We remove the libsass Python requirement as it doesn't seem to be used
any more. (I was able to compile ORA's assets by running `make static`;
no Python dependencies needed.) Removing libsass from ORA's requirements
will allow us to move it out of edx-platform's base requirements and into a new
static-asset-compilation-specific requirements stage.

Libsass [1] is a deprecated Sass compilation library written in C,
and installing it into edx-platform adds a whole minute to the
build because there are no pre-compiled binaries available
for the version we install.

1. https://sass-lang.com/libsass/

Closes: #1986
  • Loading branch information
kdmccormick authored Jul 18, 2023
1 parent c2a59ee commit f9355d1
Show file tree
Hide file tree
Showing 8 changed files with 3 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ clean: ## remove generated byte code, coverage reports, and build artifacts
##################

install-python: ## Install python dependencies
pip install -r requirements/base.txt --only-binary=lxml,libsass
pip install -r requirements/base.txt --only-binary=lxml

install-js: ## install JavaScript dependencies
npm install
Expand Down
2 changes: 1 addition & 1 deletion openassessment/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""
Initialization Information for Open Assessment Module
"""
__version__ = '5.1.1'
__version__ = '5.2.0'
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "edx-ora2",
"version": "5.1.1",
"version": "5.2.0",
"repository": "https://github.com/openedx/edx-ora2.git",
"dependencies": {
"@edx/frontend-build": "^6.1.1",
Expand Down
1 change: 0 additions & 1 deletion requirements/base.in
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ defusedxml
django-model-utils
jsonfield
lazy
libsass
loremipsum
lxml
path.py
Expand Down
2 changes: 0 additions & 2 deletions requirements/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ jsonfield==3.1.0
# edx-submissions
lazy==1.5
# via -r requirements/base.in
libsass==0.22.0
# via -r requirements/base.in
loremipsum==1.0.5
# via
# -c requirements/constraints.txt
Expand Down
2 changes: 0 additions & 2 deletions requirements/quality.txt
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,6 @@ lazy==1.5
# via -r requirements/test.txt
lazy-object-proxy==1.9.0
# via astroid
libsass==0.22.0
# via -r requirements/test.txt
loremipsum==1.0.5
# via
# -c requirements/constraints.txt
Expand Down
2 changes: 0 additions & 2 deletions requirements/test-acceptance.txt
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,6 @@ lazy==1.5
# via
# -r requirements/test.txt
# bok-choy
libsass==0.22.0
# via -r requirements/test.txt
loremipsum==1.0.5
# via
# -c requirements/constraints.txt
Expand Down
2 changes: 0 additions & 2 deletions requirements/test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,6 @@ junit-xml==1.9
# via cfn-lint
lazy==1.5
# via -r requirements/base.txt
libsass==0.22.0
# via -r requirements/base.txt
loremipsum==1.0.5
# via
# -c requirements/constraints.txt
Expand Down

0 comments on commit f9355d1

Please sign in to comment.