-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for translations by default in cookiecutter-django-app #401
Comments
It looks like most of our repos use conf/locale. A few have just locale -- but for about half of those it's just a symlink to conf/locale. I'm not sure how to test this, but does it work to just have a recursive-include of conf/locale? |
Diana Huang hi folks. this was a ticket that came in to Arch-BOM and i don't think we're going to get to it: #401 i'm not sure if someone on this team/WG can take a look and make a call on how it should be handled? #401 Add support for translations by default in cookiecutter-django-app
These changes will allow translations included in the locale folder to be automatically recognized by the platform. In addition, the make extract_translations and make compile_translations commands should not be modified, as they work with these changes. |
from my side, I am not sure as well, but in any case according to latest changes of translations process OEP58, were are translations are saved openedx-translatiosn repo, |
@OmarIthawi @shadinaif please provide feedback. |
@shadinaif could you please look into this request. I'd like to see if any of the recent work we've done have changed translations support in this repository. |
@OmarIthawi @brian-smith-tcril Was this repository updated as part of OEP-58? I might be misunderstanding, but in the django app template Makefile I see calls to |
Thank you for reporting this @kdmccormick ! We've done some work in this repo, it's hard to immediately answer if we missed a mandatory change or if it's just a stale code. I'll double-check early next week and let you know. Thank you! |
update: this repo is a bit special. Because it's a template for new plugins that are used inside and outside edx.org. Not everyone wants to use Please keep the issue open, I'll link it to the fix PR |
Description
If you add translations in the
conf/locale
folder they are not rendered on the platform.To make it work by default on the platform, the following changes can be made. These changes were successfully tested in this plugin
Move all files from
conf/locale
tolocale
.Update
MANIFEST.in
file to include the newlocale
folder at the time of package installation.These changes will allow translations included in the
locale
folder to be automatically recognized by the platform. In addition, themake extract_translations
andmake compile_translations
commands should not be modified, as they work with these changes.The text was updated successfully, but these errors were encountered: