Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Be able to build wheels for publishing. #94

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

feanil
Copy link

@feanil feanil commented Apr 12, 2024

Previously wheel would just be installed wherever we needed it but
python environment tooling seems to be moving away from that so
explicitly install it since we need it for building and publishing
wheels.

feanil added 2 commits April 12, 2024 10:02
Previously wheel would just be installed wherever we needed it but
python environment tooling seems to be moving away from that so
explicitly install it since we need it for building and publishing
wheels.
Codecov is failing more often without this token so update to the latest
version and add a token to the github actions secrets for this repo that
can be used to fix coverage uploading.
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (1369f33) to head (8bd4746).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   97.78%   97.78%           
=======================================
  Files           4        4           
  Lines         226      226           
  Branches       13       13           
=======================================
  Hits          221      221           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feanil feanil merged commit c5c9fa1 into master Apr 16, 2024
8 checks passed
@feanil feanil deleted the feanil/update_publishing branch April 16, 2024 17:54
@feanil feanil linked an issue Apr 16, 2024 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test ccx-keys on Python 3.11
2 participants