Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate OpenCraft's dynamic theme loading proposals #284

Closed
Tracked by #304
arbrandes opened this issue May 31, 2022 · 2 comments
Closed
Tracked by #304

Evaluate OpenCraft's dynamic theme loading proposals #284

arbrandes opened this issue May 31, 2022 · 2 comments
Assignees
Labels
community frontend Frontend-related tasks

Comments

@arbrandes
Copy link
Contributor

arbrandes commented May 31, 2022

See the initial conceptual PR:

openedx/frontend-app-discussions#125

It was followed up by two different ADRs:

These two should be reviewed and evaluated by tCRIL, and also other members of the community. This ticket encompasses our review, as well as getting others to review it (publicizing it, etc.)

The review should also focus on how this would interoperate with the MFE configuration API being worked on by eduNext.

The publicizing should happen after Kshitij comes back from leave on July 18th, so that he can be around to answer comments.

@arbrandes arbrandes self-assigned this May 31, 2022
@arbrandes arbrandes added frontend Frontend-related tasks community labels May 31, 2022
@jmakowski1123 jmakowski1123 moved this from To Do - Backlog to To Do - Prioritized in Axim Engineering Tasks Jun 10, 2022
@arbrandes arbrandes moved this from To Do - Prioritized for Current Sprint to To Do - Backlog in Axim Engineering Tasks Jun 23, 2022
@jmakowski1123 jmakowski1123 moved this from To Do - Backlog to To Do - Prioritized for Current Sprint in Axim Engineering Tasks Jun 27, 2022
@arbrandes
Copy link
Contributor Author

I found today that this has expanded into two more PRs, this time for ADRs:

openedx/paragon#1388

and

openedx/frontend-platform#351

I believe we should carry this over into the next sprint.

@arbrandes arbrandes changed the title Evaluate Kshitij's dynamic theme loading concept Evaluate OpenCraft's dynamic theme loading proposals Jul 7, 2022
@arbrandes
Copy link
Contributor Author

OpenCraft is going to revisit this in conversation with 2U about the latter's work on Design Tokens.

Repository owner moved this from To Do - Prioritized for Current Sprint to Done in Axim Engineering Tasks Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community frontend Frontend-related tasks
Projects
None yet
Development

No branches or pull requests

1 participant