-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove xblockutils in Favor of xblock.utils #91
Conversation
Thanks for the pull request, @abdullahQureshee! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@abdullahQureshee Hi, thanks for creating this. Instead of removing the xblockutils completely can you use try/catch to support versions older than Quince as mentioned in the original ticket: openedx/axim-engineering#915 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me now.
Thanks for your contribution, keep it up ⭐
recommender/recommender.py
Outdated
@@ -24,7 +24,7 @@ | |||
from xblock.fields import Scope, List, Dict, Boolean, String, JSONField | |||
from web_fragments.fragment import Fragment | |||
from xblock.reference.plugins import Filesystem | |||
from xblockutils.resources import ResourceLoader | |||
from xblock.utils.resources import ResourceLoader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should provide backward compatibility, study the following thread
openedx/xblock-drag-and-drop-v2#357 (comment)
@abdullahQureshee Please fulfill your CLA requirements to merge this PR. |
Hi @abdullahQureshee! Are
@abdullahQureshee - if you are contributing on behalf of edly, please have your manager reach out to [email protected] to have you added to the exisiting entity agreement with us. Thanks! |
@navinkarkera please have a look at it again. Let me know if updates are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdullahQureshee Thanks! Looks good 👍
@navinkarkera Can you please push the updated release of this xblock to pypi, so we get its update on |
@farhan Done. All runners seem to be stuck for now but they should be resume soon, publish job log |
Issue #89