Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xblockutils in Favor of xblock.utils #91

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

abdullahQureshee
Copy link
Contributor

@abdullahQureshee abdullahQureshee commented Aug 1, 2024

Issue #89

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 1, 2024

Thanks for the pull request, @abdullahQureshee!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @navinkarkera. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 1, 2024
@navinkarkera
Copy link
Contributor

@abdullahQureshee Hi, thanks for creating this. Instead of removing the xblockutils completely can you use try/catch to support versions older than Quince as mentioned in the original ticket: openedx/axim-engineering#915 (comment)

Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me now.
Thanks for your contribution, keep it up ⭐

@@ -24,7 +24,7 @@
from xblock.fields import Scope, List, Dict, Boolean, String, JSONField
from web_fragments.fragment import Fragment
from xblock.reference.plugins import Filesystem
from xblockutils.resources import ResourceLoader
from xblock.utils.resources import ResourceLoader
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should provide backward compatibility, study the following thread
openedx/xblock-drag-and-drop-v2#357 (comment)

@farhan
Copy link

farhan commented Aug 9, 2024

@abdullahQureshee Please fulfill your CLA requirements to merge this PR.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 12, 2024
@mphilbrick211
Copy link

Hi @abdullahQureshee! Are

@abdullahQureshee Please fulfill your CLA requirements to merge this PR.

@abdullahQureshee - if you are contributing on behalf of edly, please have your manager reach out to [email protected] to have you added to the exisiting entity agreement with us. Thanks!

@abdullahQureshee
Copy link
Contributor Author

@navinkarkera please have a look at it again. Let me know if updates are required.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 22, 2024
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdullahQureshee Thanks! Looks good 👍

@navinkarkera navinkarkera merged commit 55d4aa0 into openedx:master Aug 23, 2024
4 checks passed
@farhan farhan mentioned this pull request Aug 25, 2024
@farhan
Copy link

farhan commented Sep 16, 2024

@navinkarkera Can you please push the updated release of this xblock to pypi, so we get its update on edx-platform and decrease the warning logs which this PR is fixing.

@navinkarkera
Copy link
Contributor

@farhan Done. All runners seem to be stuck for now but they should be resume soon, publish job log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants