Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle exceptions without a message attribute on compile translations e.g. FileNotFoundError #74

Conversation

ArturGaspar
Copy link
Contributor

Description

Avoids causing another exception in the exception handling of compile_translations() in installation.

Testing instructions

  1. Install in an environment where compiling translations will fail with FileNotFoundError (e.g. if msgfmt is not installed)
  2. See that installation succeeds

Other information

Private-ref: https://tasks.opencraft.com/browse/BB-8077

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 18, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211
Copy link

Hi @ArturGaspar! Is this ready for review?

@ArturGaspar
Copy link
Contributor Author

@mphilbrick211 Yes.

@mphilbrick211
Copy link

Hi @openedx/2u-arbi-bom! Would some be able to please review / merge this for us? Thanks!

@mphilbrick211
Copy link

Hi @awais786! Are you still able to review / merge this?

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 20, 2024
@iamsobanjaved
Copy link
Contributor

@ArturGaspar Kindly rebase the PR.

@ArturGaspar ArturGaspar force-pushed the artur/compile-translations-error-handling branch from 12ffdaa to 7b17794 Compare February 21, 2024 06:04
@ArturGaspar
Copy link
Contributor Author

@iamsobanjaved Done.

@iamsobanjaved iamsobanjaved merged commit 27e2259 into openedx:master Feb 23, 2024
3 checks passed
@openedx-webhooks
Copy link

@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants