-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle exceptions without a message attribute on compile translations e.g. FileNotFoundError #74
fix: handle exceptions without a message attribute on compile translations e.g. FileNotFoundError #74
Conversation
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @ArturGaspar! Is this ready for review? |
@mphilbrick211 Yes. |
Hi @openedx/2u-arbi-bom! Would some be able to please review / merge this for us? Thanks! |
Hi @awais786! Are you still able to review / merge this? |
@ArturGaspar Kindly rebase the PR. |
…tions E.g. FileNotFoundError.
12ffdaa
to
7b17794
Compare
@iamsobanjaved Done. |
@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Avoids causing another exception in the exception handling of compile_translations() in installation.
Testing instructions
Other information
Private-ref: https://tasks.opencraft.com/browse/BB-8077