Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Make ARM64 plugin official, with upstream images #81

Closed
kdmccormick opened this issue Jun 22, 2022 · 7 comments
Closed

Make ARM64 plugin official, with upstream images #81

kdmccormick opened this issue Jun 22, 2022 · 7 comments
Assignees

Comments

@kdmccormick
Copy link
Collaborator

kdmccormick commented Jun 22, 2022

Context

In #35, we resolved many of the blockers to running Tutor on ARM64. Thanks to @bradenmacdonald, there is a now a plugin that can be easily installed to enable ARM64 support: https://github.com/open-craft/tutor-contrib-arm64

This is great progress, but it's not sufficient for "ARM64 works out-of-the-box". See overhangio/tutor#650 for more discussion on this topic.

Acceptance Criteria

Roll ARM64 support into the base Tutor installation. One way to do this would be by making tutor-contrib-arm64 an official pre-installed plugin (which could be enabled as needed, perhaps even automatically). In this case, the plugin would need a dedicated maintainer.

If we want there to be hosted upstream ARM64 images for Tutor, then we need a sustainable way to host those and keep them up to date.

@bradenmacdonald
Copy link

BTW I recently updated the ARM images for the plugin so they should have a Nutmeg build as well as recent master working well.

@bradenmacdonald
Copy link

See discussion at open-craft/tutor-contrib-arm64#1 and open-craft/tutor-contrib-arm64#3

My perspective is that once Tutor is using MySQL 8 by default, the plugin will only be useful for providing default images. If @regisb is interested in using the code from open-craft/tutor-contrib-arm64#3 to do automated multi-arch builds by default (which I think is de-risked now that I have it working), then there is no need for the plugin at all. But if he doesn't want to maintain those, then we'll need to keep the plugin going to allow people to switch to the unofficial images.

@regisb
Copy link

regisb commented Apr 26, 2023

I agree that we should integrate this plugin in Tutor core such that arm64 users don't have to perform any extra steps. I'm grateful for Braden's suggestion to integrate the plugin code into Tutor core, so I suggest that we do exactly that starting from Palm. Thanks a lot!

@kdmccormick
Copy link
Collaborator Author

This is fantastic to hear, thank you both!

@regisb , I'm assigning you to this issue since you know the next steps best, but let us know if there's any way the community can help

@kdmccormick kdmccormick moved this from 📥 New to 📋 Refined in Developer Experience Working Group Apr 27, 2023
@kdmccormick
Copy link
Collaborator Author

notes from devx meeting:

ARM64 plugin will be obviated by Palm.

to do: come back and check that we are all set here

are there more images to build?

@regisb
Copy link

regisb commented May 29, 2023

are there more images to build?

Oh yes! Basically, all images for all plugins. So far, there are a few which I have not managed to build. Here is the list: https://github.com/search?q=org%3Aoverhangio+IMAGES_BUILD_PLATFORM&type=code
(this is the CI option that configures image building for amd64 only)

@kdmccormick kdmccormick moved this from Refined to In Progress in Developer Experience Working Group Jun 2, 2023
@kdmccormick
Copy link
Collaborator Author

The remaining plugins without ARM64 images are:

I'm going to close this since the big lift has already been done (thanks Braden and Régis!), and I'll track overhangio/tutor-forum#23 as a follow-up for the forums.

@github-project-automation github-project-automation bot moved this from 📋 To Do to 🚀 Closed in Tutor DevEnv Adoption Sep 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Developer Experience Working Group Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants