Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Load mysql dump to speed up migrations during quickstart #63

Closed
kdmccormick opened this issue May 19, 2022 · 4 comments
Closed

Load mysql dump to speed up migrations during quickstart #63

kdmccormick opened this issue May 19, 2022 · 4 comments

Comments

@kdmccormick
Copy link
Collaborator

kdmccormick commented May 19, 2022

Context

TBD

Acceptance

TBD

@ARMBouhali
Copy link

ARMBouhali commented Jan 6, 2023

So instead of long init tasks passing through django management commands, one can generate sql files out of these and offer to apply them as conditional init tasks.

I like the idea and I am interested in seeing how deep we can go implementing it .

@regisb
Copy link

regisb commented Jan 9, 2023

For the record, this is a question that was raised before: overhangio/tutor#238
This feature is more feasible now that we have a more extensive plugin API. Still, I think that loading a dump instead of running migrations would cause more issues than it would resolve. I'd love to be proven wrong, though.

@kdmccormick
Copy link
Collaborator Author

I think this issue has a lot of potential for increasing launch speed, but also comes with maintenance challenges. Specifically: the sql files would need to be updated regularly as init tasks are changed, both in Tutor and in the underlying upstream management commands. Django upgrades can affect the sql dump, too.

I would be supportive if someone wanted to implement this a plugin and propose a maintenance plan for the plugin, probably including automatic regeneration of the dumps using vanilla Tutor. I think vanilla Tutor should continue to use management commands, as they are more human-readable than SQL, and they largely come pre-written for us from upstream.

@kdmccormick
Copy link
Collaborator Author

kdmccormick commented Mar 28, 2024

In the grand scheme of things, Tutor launch time is pretty darn good, so I'm not keen on spending time on this and potentially introducing bugs. I'm going to close this, and we can come back to it if we find that Tutor launch isn't fast enough.

@kdmccormick kdmccormick closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
@github-project-automation github-project-automation bot moved this from 📋 To Do to 🚀 Closed in Tutor DevEnv Adoption Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants