This repository has been archived by the owner on May 1, 2024. It is now read-only.
fix: Added support for django42 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awais786
reviewed
Sep 8, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 97.52% 97.51% -0.01%
==========================================
Files 54 53 -1
Lines 3026 3023 -3
Branches 266 266
==========================================
- Hits 2951 2948 -3
Misses 63 63
Partials 12 12
☔ View full report in Codecov by Sentry. |
UsamaSadiq
suggested changes
Sep 19, 2023
iamsobanjaved
force-pushed
the
zshkoor/django42-support
branch
from
66aeb2c to
0c8b3d8
Compare
iamsobanjaved
approved these changes
Sep 27, 2023
| @@ -32,7 +32,7 @@ def get(self, request, *args, **kwargs): | |||
| self.course_id = self.kwargs.get('course_id') | |||
| start_date = request.query_params.get('start_date') | |||
| end_date = request.query_params.get('end_date') | |||
| timezone = utc | |||
| timezone = datetime.timezone.utc | |||
There was a problem hiding this comment.
Reason for this change
The django.utils.timezone.utc alias to datetime.timezone.utc is deprecated. Use datetime.timezone.utc directly.
iamsobanjaved
force-pushed
the
zshkoor/django42-support
branch
from
0c8b3d8 to
2bfdfe6
Compare
UsamaSadiq
approved these changes
Oct 5, 2023
zacharis278
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue