Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Run test on Django 4.2 #4076

Closed
wants to merge 4 commits into from

Conversation

mumarkhan999
Copy link
Contributor

⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH

  • I have checked the branch to which I would like to merge.

⛔️ DEPRECATION WARNING

This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.

Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]

Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Required Testing

  • Before deploying this change, complete a purchase in the stage environment.
    (^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)

Description

Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author", "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, OpenEdx vs. edx.org differences, development vs. production environment differences, security, or accessibility.

@mumarkhan999 mumarkhan999 requested a review from a team as a code owner December 18, 2023 10:21
@mumarkhan999 mumarkhan999 force-pushed the umar/update-tox-for-django42 branch 21 times, most recently from 5694f71 to 5c45b3e Compare December 20, 2023 14:21
@mumarkhan999 mumarkhan999 force-pushed the umar/update-tox-for-django42 branch from 5c45b3e to a311640 Compare December 20, 2023 14:49
@mumarkhan999 mumarkhan999 force-pushed the umar/update-tox-for-django42 branch 4 times, most recently from 878576b to 4333351 Compare December 22, 2023 09:44
@mumarkhan999 mumarkhan999 force-pushed the umar/update-tox-for-django42 branch 4 times, most recently from b19d991 to 70462bf Compare December 27, 2023 13:20
@mumarkhan999 mumarkhan999 force-pushed the umar/update-tox-for-django42 branch from 70462bf to 9213f1c Compare December 27, 2023 13:35
@mumarkhan999 mumarkhan999 changed the title update tox.ini for django42 RRun test on Django 4.2 Jan 5, 2024
@mumarkhan999 mumarkhan999 changed the title RRun test on Django 4.2 Run test on Django 4.2 Jan 5, 2024
Copy link
Contributor

@christopappas christopappas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumarkhan999
Copy link
Contributor Author

django itself is not update to 4.2 here: https://github.com/openedx/ecommerce/pull/4076/files#diff-0940fec0afe21798f617cc4522db676f15769ae28a72992b8d19216ef7b1c3b5L106

Already aware of that. The upgrade job was failing on github and locally so just added test support for django42.
@zubair-ce07 will update the actual version.

@feanil feanil closed this Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants