Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that it runs out of the box #191

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 26, 2024

This is checking two slightly different things:

  • Can we run the end-to-end test with only a couple extra packages besides what a user would get when they install this package? We want to be sure that we aren't relying on dev dependencies in the production code by mistake.
  • Can we run the end-to-end test with unpinned dependencies? We want to know if newer versions have introduced breaking changes. (We'll keep the pinned dependencies, too, so if something does go wrong with the unpinned deps, we know who is to blame.)

@mccalluc
Copy link
Contributor Author

This is curious: I can reproduce the failure locally, but only the first time I run in a given venv. The second time through it passes. Possible that something is taking a long time to install in the background, and the second time through it is cached?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Pending
Development

Successfully merging this pull request may close these issues.

Is this a library or an application?
1 participant