Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't Zoom Out of Some PDFs #349

Open
TechD123 opened this issue May 30, 2024 · 5 comments
Open

Can't Zoom Out of Some PDFs #349

TechD123 opened this issue May 30, 2024 · 5 comments

Comments

@TechD123
Copy link

Since I started using the app with version 3.19, some PDFs are displayed with a zoom factor above 100% when opening them, meaning the entire page can't be seen. It's impossible to make the entire page fit, even though the document appears to be A4 sized. In my experience, this has affected 1/10 PDFs.

The problem is still present in 3.26.

Here's a link to a PDF for which this is the case.

@andiwand
Copy link
Member

@TomTasche @ViliusSutkus89 I suppose this is something that changed with the pdf2htmlEX update?

@ViliusSutkus89
Copy link
Contributor

3.19 was built against pdf2htmlEX-Android 0.18.16, which was built against pdf2htmlEX-v0.18.7-poppler-0.81.0
3.24 is built against pdf2htmlEX-Android 0.18.23, which is built against pdf2htmlEX-0.18.8.rc1 + rc2 patches

So yes, there were a lot of changes both in our packaging and in the upstream pdf2htmlEX.

I got some luck getting the document to fit properly by using setFitWidth, which calls fit-width, but I'm not entirely sure what's the proper default value for it

@ViliusSutkus89
Copy link
Contributor

We could add a settings menu to expose those options as configurables

@TechD123
Copy link
Author

TechD123 commented Nov 3, 2024

Reproducible with 3.32-pro

@TomTasche
Copy link
Member

I got some luck getting the document to fit properly by using setFitWidth, which calls fit-width, but I'm not entirely sure what's the proper default value for it

Could you use the screen width? Maybe with a static offset of 50 pixel or so, to make sure we don't overlap with scrollbar, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants