From 15cf2de13cdc50447f729d0f2071df58397b667c Mon Sep 17 00:00:00 2001
From: Etienne Burdet <etienne.burdet@hey.com>
Date: Fri, 5 Apr 2024 12:27:34 +0200
Subject: [PATCH] fix: merge install and build steps

---
 .github/workflows/visualizations.yml              | 15 +++------------
 package.json                                      |  1 +
 .../src/components/Chart/Chart.svelte             |  2 --
 3 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/visualizations.yml b/.github/workflows/visualizations.yml
index 3ff906db..1508d6ed 100644
--- a/.github/workflows/visualizations.yml
+++ b/.github/workflows/visualizations.yml
@@ -31,12 +31,9 @@ jobs:
         uses: actions/setup-node@v1
         with:
           node-version: ${{ matrix.node }}
-      
-      - name: Install
-        run: npm ci
 
       - name: Build
-        run: npm ci --workspaces --include-workspace-root --install-links
+        run: npm run build-ci
 
       - name: Test
         run: npm test
@@ -59,11 +56,8 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
 
-      - name: Install
-        run: npm ci
-
       - name: Build
-        run: npm install
+        run: npm run build-ci
 
       - name: Lint
         run: npm run lint
@@ -88,11 +82,8 @@ jobs:
         with:
           node-version: ${{ matrix.node }}
 
-      - name: Install
-        run: npm ci
-
       - name: Build
-        run: npm install
+        run: npm build-ci
 
       - name: Build storybook
         run: npm run build-storybook
diff --git a/package.json b/package.json
index b36cb252..6f4f20b7 100644
--- a/package.json
+++ b/package.json
@@ -27,6 +27,7 @@
     "packages/*"
   ],
   "scripts": {
+    "build-ci": "npm ci --workspaces --include-workspace-root --install-links",
     "test": "lerna run test --parallel --no-bail",
     "watch": "lerna run watch --parallel --stream",
     "lint": "lerna run lint:prettier:check,lint:eslint:check  --parallel --no-bail",
diff --git a/packages/visualizations/src/components/Chart/Chart.svelte b/packages/visualizations/src/components/Chart/Chart.svelte
index e60a6a76..4747fc88 100644
--- a/packages/visualizations/src/components/Chart/Chart.svelte
+++ b/packages/visualizations/src/components/Chart/Chart.svelte
@@ -85,8 +85,6 @@
          * To be deleted when fully switching to home made one */
         const legend = options.legend?.custom ? { display: false } : buildLegend(options);
         chartOptions.aspectRatio = defaultValue(options.aspectRatio, 4 / 3);
-        chartOptions.maintainAspectRatio = true;
-        chartOptions.responsive = true;
         chartOptions.scales = buildScales(options);
         chartOptions.layout = {
             padding: defaultValue(options?.padding, 12),