Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Ibm dev rebased #255

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Ibm dev rebased #255

wants to merge 43 commits into from

Conversation

prashantgupta24
Copy link

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

simon-mo and others added 30 commits December 3, 2024 10:38
@openshift-ci openshift-ci bot requested review from heyselbi and Xaenalt December 3, 2024 18:49
Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prashantgupta24
Once this PR has been reviewed and has the lgtm label, please assign rpancham for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FROM vllm-openai as vllm-grpc-adapter

USER root

RUN --mount=type=cache,target=/root/.cache/pip \
--mount=type=cache,target=/root/.cache/uv \
--mount=type=bind,from=build,src=/workspace/dist,target=/workspace/dist \
HOME=/root uv pip install $(echo dist/*.whl)'[tensorizer]' vllm-tgis-adapter==0.5.3
uv pip install $(echo /workspace/dist/*.whl)'[tensorizer]' --verbose && \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue in this Dockerfile at line 188 (not part of this PR) which prevents the dockerfile from building. You can either rebase on main or cherry pick 039e209 to fix the issue.

Copy link

openshift-ci bot commented Dec 4, 2024

@prashantgupta24: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cuda-pr-image-mirror 87ebca7 link true /test cuda-pr-image-mirror
ci/prow/smoke-test 87ebca7 link true /test smoke-test
ci/prow/rocm-pr-image-mirror 87ebca7 link true /test rocm-pr-image-mirror
ci/prow/images 87ebca7 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.