Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.ubi: enable sccache caching #178

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented Oct 3, 2024

  • cherry pick from upstream: [CI/Build] Fix machete generated kernel files ordering (8976)
  • Dockerfile.ubi: silence docker build warnings
  • Dockerfile.ubi: adjust max_jobs/nvcc_threads
  • Dockerfile.ubi: use sccache
  • Dockerfile.ubi: switch from build args to --mount=type=secret

Usage example:

export AWS_ACCESS_KEY_ID=<key>
export AWS_SECRET_ACCESS_KEY=<key>

docker build --tag vllm:sccache-test -f Dockerfile.ubi --progress=plain --build-arg=max_jobs=12 --build-arg=nvcc_threads=2 --secret id=AWS_ACCESS_KEY_ID --secret id=AWS_SECRET_ACCESS_KEY

Copy link

openshift-ci bot commented Oct 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@dtrifiro dtrifiro force-pushed the add-shared-sccache-bucket branch from 656d353 to 0250934 Compare October 3, 2024 16:21
@dtrifiro dtrifiro force-pushed the add-shared-sccache-bucket branch 3 times, most recently from 54a89ff to 82df897 Compare October 3, 2024 16:54
@dtrifiro dtrifiro force-pushed the add-shared-sccache-bucket branch from 82df897 to 93f347e Compare October 4, 2024 08:53
riprasad pushed a commit to red-hat-data-services/vllm that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants