A reconciler should not require the DSCI to perform cleanup action to avoid deadlock #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
requested review from
zdtsw and
VaishnaviHire
and removed request for
AjayJagan
lburgazzoli
force-pushed
the
dsci-less
branch
from
78944cb to
a8a9821
Compare
… avoid deadlock When the common reconciler detect that a resource is amrked for deletion, it shoudl not try to lookup the DSCI as it should be possible to remove a resource even if the DSCI is not present to avoid deadlocks. To make the code more clear, the Reconcile method has been split in: - delete, which triggers the execution of the finalizer actions - apply, which triggers the execution od the reconcile actions Signed-off-by: Luca Burgazzoli <[email protected]>
lburgazzoli
force-pushed
the
dsci-less
branch
from
a8a9821 to
668a64d
Compare
|
/test opendatahub-operator-e2e |
zdtsw
approved these changes
Dec 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1429 +/- ##
=======================================
Coverage ? 25.60%
=======================================
Files ? 67
Lines ? 5519
Branches ? 0
=======================================
Hits ? 1413
Misses ? 3933
Partials ? 173 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the common reconciler detect that a resource is amrked for
deletion, it shoudl not try to lookup the DSCI as it should be possible
to remove a resource even if the DSCI is not present to avoid deadlocks.
To make the code more clear, the Reconcile method has been split in:
Notes:
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).The developer has manually tested the changes and verified that the changes work