Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfiles to Go 1.22 (Go 1.22: 1/3) #1424

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

grdryn
Copy link
Member

@grdryn grdryn commented Dec 6, 2024


JIRA: https://issues.redhat.com/browse/RHOAIENG-16819

Description

The UBI8 go-toolset image that we use for building is already on 1.22,
so I don't think there's any reason to remain bound to 1.21.

Also, upstream Go only support the two most recent minor versions:
currently that means 1.23 and 1.22; 1.21 is no longer receiving any
updates from the Go developers.

How Has This Been Tested?

  • Builds fine
  • Runs fine

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6d836db). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1424   +/-   ##
=======================================
  Coverage        ?   25.81%           
=======================================
  Files           ?       68           
  Lines           ?     5550           
  Branches        ?        0           
=======================================
  Hits            ?     1433           
  Misses          ?     3944           
  Partials        ?      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grdryn
Copy link
Member Author

grdryn commented Dec 6, 2024

/cc @zdtsw @VaishnaviHire

@openshift-ci openshift-ci bot requested review from VaishnaviHire and zdtsw December 6, 2024 17:11
@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2024
@openshift-ci openshift-ci bot removed the lgtm label Dec 10, 2024
@grdryn grdryn changed the title chore: update to Go 1.22 Update Dockerfiles to Go 1.22 Dec 10, 2024
@grdryn
Copy link
Member Author

grdryn commented Dec 10, 2024

After a discussion today, what was originally in this PR will now be split into 3 PRs.

  • This first one will just have the change to the Dockerfiles, since everything should work as expected by just using a newer version of Go to build, even with the older version set as the minimum version in go.mod
  • The second PR will just update the go.mod, but will not fix linter errors (will just silence those that prevent the build from working)
  • The third PR will address the linter warnings/errors

@grdryn grdryn mentioned this pull request Dec 10, 2024
5 tasks
@grdryn grdryn changed the title Update Dockerfiles to Go 1.22 Update Dockerfiles to Go 1.22 (Go 1.22: 1/3) Dec 10, 2024
@ykaliuta
Copy link
Contributor

probably, README.md should be updated as well for consistency

@grdryn
Copy link
Member Author

grdryn commented Dec 11, 2024

@ykaliuta I don't think this change is where the README should be updated, since this change doesn't require 1.22 as a prerequisite for development. I've instead updated the README as part of #1439, since that's where it becomes necessary.

JIRA: https://issues.redhat.com/browse/RHOAIENG-16819

The UBI8 go-toolset image that we use for building is already on 1.22,
so I don't think there's any reason to remain bound to 1.21.

Also, upstream Go only support the two most recent minor versions:
currently that means 1.23 and 1.22; 1.21 is no longer receiving any
updates from the Go developers.
Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 10f47df into opendatahub-io:main Dec 11, 2024
10 checks passed
@grdryn grdryn deleted the go1.22-main branch December 11, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants