-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfiles to Go 1.22 (Go 1.22: 1/3) #1424
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
=======================================
Coverage ? 25.81%
=======================================
Files ? 68
Lines ? 5550
Branches ? 0
=======================================
Hits ? 1433
Misses ? 3944
Partials ? 173 ☔ View full report in Codecov by Sentry. |
/cc @zdtsw @VaishnaviHire |
pkg/controller/actions/render/kustomize/action_render_manifests_test.go
Outdated
Show resolved
Hide resolved
After a discussion today, what was originally in this PR will now be split into 3 PRs.
|
probably, README.md should be updated as well for consistency |
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 The UBI8 go-toolset image that we use for building is already on 1.22, so I don't think there's any reason to remain bound to 1.21. Also, upstream Go only support the two most recent minor versions: currently that means 1.23 and 1.22; 1.21 is no longer receiving any updates from the Go developers.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10f47df
into
opendatahub-io:main
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819
Description
The UBI8 go-toolset image that we use for building is already on 1.22,
so I don't think there's any reason to remain bound to 1.21.
Also, upstream Go only support the two most recent minor versions:
currently that means 1.23 and 1.22; 1.21 is no longer receiving any
updates from the Go developers.
How Has This Been Tested?
Screenshot or short clip
Merge criteria