Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to watch/own object not known when the operator starts, but only after a component has been enabled. #1385

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Nov 19, 2024

Signed-off-by: Luca Burgazzoli [email protected]

Description

https://issues.redhat.com/browse/RHOAIENG-15170

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-operator-refactor@d044d64). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             feature-operator-refactor    #1385   +/-   ##
============================================================
  Coverage                             ?   26.85%           
============================================================
  Files                                ?       55           
  Lines                                ?     4428           
  Branches                             ?        0           
============================================================
  Hits                                 ?     1189           
  Misses                               ?     3098           
  Partials                             ?      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli lburgazzoli requested review from zdtsw and VaishnaviHire and removed request for CFSNM and Sara4994 November 20, 2024 11:09
@VaishnaviHire
Copy link
Member

@lburgazzoli Is there a way we can test this?

@lburgazzoli
Copy link
Contributor Author

@lburgazzoli Is there a way we can test this?

there is a validateOperandsDynamicallyWatchedResources test for modelmesh which ensure that a dynamically watched resources is reverted in case it gets changed. I'm adding a similar one for the dashboard

We may also add some test based on the metrics endpoint since the number of dynamically watched resources is tracked.

@lburgazzoli lburgazzoli force-pushed the RHOAIENG-15170-watch branch 4 times, most recently from fab6bc1 to b6efa2f Compare November 20, 2024 15:05
…nly after a component has been enabled.

Signed-off-by: Luca Burgazzoli <[email protected]>
@lburgazzoli
Copy link
Contributor Author

I'm adding a similar one for the dashboard

@VaishnaviHire done

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VaishnaviHire,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 74b3e85 into opendatahub-io:feature-operator-refactor Nov 20, 2024
10 checks passed
@lburgazzoli lburgazzoli deleted the RHOAIENG-15170-watch branch November 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants