-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to watch/own object not known when the operator starts, but only after a component has been enabled. #1385
Conversation
f2a9759
to
6195195
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-operator-refactor #1385 +/- ##
============================================================
Coverage ? 26.85%
============================================================
Files ? 55
Lines ? 4428
Branches ? 0
============================================================
Hits ? 1189
Misses ? 3098
Partials ? 141 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
6195195
to
342a3c4
Compare
/test opendatahub-operator-e2e |
342a3c4
to
dffebab
Compare
@lburgazzoli Is there a way we can test this? |
there is a We may also add some test based on the metrics endpoint since the number of dynamically watched resources is tracked. |
fab6bc1
to
b6efa2f
Compare
…nly after a component has been enabled. Signed-off-by: Luca Burgazzoli <[email protected]>
b6efa2f
to
69a86f1
Compare
@VaishnaviHire done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
74b3e85
into
opendatahub-io:feature-operator-refactor
Signed-off-by: Luca Burgazzoli [email protected]
Description
https://issues.redhat.com/browse/RHOAIENG-15170
How Has This Been Tested?
Screenshot or short clip
Merge criteria