[sync]: Cleanup NIM integration tech preview resources #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ahub-io#1369) * chore: cleanup nim integration tech preview resources Signed-off-by: Tomer Figenblat <[email protected]> * chore: apply suggestions from code review Co-authored-by: Wen Zhou <[email protected]> * chore: addressed pr reviews, better logging Signed-off-by: Tomer Figenblat <[email protected]> * chore: set nim cleanup for minors 14 and 15 Signed-off-by: Tomer Figenblat <[email protected]> * chore: nim tp cleanup should remove api key secret Signed-off-by: Tomer Figenblat <[email protected]> * chore: addresed pr reviews, rewrite cleanup func Signed-off-by: Tomer Figenblat <[email protected]> --------- Signed-off-by: Tomer Figenblat <[email protected]> Co-authored-by: Wen Zhou <[email protected]> (cherry picked from commit 84d22f3)
Signed-off-by: Wen Zhou <[email protected]>
zdtsw
requested review from
etirelli and
VaishnaviHire
and removed request for
adelton and
mattmahoneyrh
TomerFi
approved these changes
Nov 14, 2024
|
@TomerFi: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: etirelli, TomerFi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1b4c4d6
into
opendatahub-io:rhoai
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync #1369
cc @TomerFi
Description
https://issues.redhat.com/browse/NVPE-32
How Has This Been Tested?
Screenshot or short clip
Merge criteria