Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sync]fix: added a filter to evicted pods when checking for ready status #1371

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[sync]fix: added a filter to evicted pods when checking for ready status #1371

merged 2 commits into from
Nov 15, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Nov 14, 2024

  • fix: added a filter to evicted pods

Signed-off-by: Alessio Pragliola [email protected]

Signed-off-by: Alessio Pragliola [email protected]
(cherry picked from commit e589680)

Description

#1334

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Al-Pragliola @zdtsw
fix: added a filter to evicted pods when checking for ready status (o…
c0fa949 
…pendatahub-io#1334)

* fix: added a filter to evicted pods

Signed-off-by: Alessio Pragliola <[email protected]>

---------

Signed-off-by: Alessio Pragliola <[email protected]>
(cherry picked from commit e589680)
@zdtsw zdtsw removed the request for review from grdryn November 14, 2024 09:59
@zdtsw
Copy link
Member Author

zdtsw commented Nov 14, 2024

/test opendatahub-operator-e2e

@zdtsw
Copy link
Member Author

zdtsw commented Nov 14, 2024

/retest

@zdtsw zdtsw added the rhoai label Nov 15, 2024
VaishnaviHire
VaishnaviHire approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fa91713 into opendatahub-io:rhoai Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

Assignees

@VaishnaviHire VaishnaviHire

Labels
approved lgtm rhoai rhoai-2.16
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdtsw @VaishnaviHire @Al-Pragliola